Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

using github's UI as preferred way to interact with code in review is a bad idea, as it encourages lazy from-the-couch-just-yolo-approve-it-looks-alright style of review. this is where gerrit+mail based workflows shine as reviewer is more encouraged to apply the series, compile/run it in their env (which might differ from your's); here is an example [0].

here are some useful notes on how to have a purely branch centric review process regardless of a webUI: [1]

[0]: https://drewdevault.com/2022/07/25/Code-review-with-aerc.htm... [1]: https://news.ycombinator.com/item?id=37086022



> mail based workflows shine as reviewer is more encouraged to apply the series, compile/run it in their env

not to mention: if the reviewer does this for every version of the posted series, on appropriately named (versioned) local branches, then they can trivially run git-range-diff between adjacent versions!





Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: