Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

When doing code reviews, I think it is annoying that every time I comment on a line, PR author gets a notification.

This is not a simultaneous, real-time thing.

I'm in the middle of doing my review, and my comments are not ready to be read. Maybe I'll change my mind on my comment on line 8 when I reach line 80.



GitLab lets you compose the entire review before submitting it so the author won't see anything until you're done.


Github does, too. You just click "Start a review" when filling out your first comment.


GitHub as well.


GitHub lets you do this, but only when writing a review for someone else. Not when addressing someone else's review, in which case your complaint 100% stands.

And yes, it absolutely drives me nuts, honestly. Why can I batch review comments, but not resolutions! Another thing Gerrit gets right! GitHub... Please...


... Another thing that mailing list-based development gets right ;) Most MUAs should know about a concept called "Drafts". I can have as many draft messages concurrently as I want, I can work on them over several days, and I can send them out (in practice) as a batch.




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: